Feature Request: Search box above section list #277 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new SectionFilter component to filter slugs based on section names Update SectionsColumn to display filtered sections Add units tests for SectionFilter component
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @ksaswin, thanks for this contribution, I love the concept! A couple small things:
|
|
Hi @octokatherine, Yeah, sounds good to me. I'll start working on those changes right away 😊 |
…/sections-typeahead
Remove search input after selecting a section Move search filter logic to SectionsColumn component Update SectionFilter unit test
|
Hi @octokatherine, I've pushed the requested changes. Please feel free to let me know if you'd like me to make any more updates to the same. Thank you 😊 |
components/SectionsColumn.js
Outdated
| setSelectedSectionSlugs((prev) => [...prev, section]) | ||
| setFocusedSectionSlug(localStorage.getItem('current-focused-slug')) | ||
| resetSearchFilter('') |
There was a problem hiding this comment.
Suggested change
| resetSearchFilter('') | |
| resetSearchFilter() |
don't think you need that argument!
There was a problem hiding this comment.
Hi @octokatherine,
Nice catch 😄 I don't know how I missed this! I've pushed the requested changes.
Thank you 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature requested in issue #277
Add new SectionFilter component to filter slugs based on section names
Update SectionsColumn to display filtered sections
Add units tests for SectionFilter component
A screenshot of the implementation:
